aboutsummaryrefslogtreecommitdiff
path: root/elf/segment.lua
diff options
context:
space:
mode:
authorSunil Nimmagadda <sunil@nimmagadda.net>2026-11-04 11:11:32 +0530
committerSunil Nimmagadda <sunil@nimmagadda.net>2026-11-04 11:11:32 +0530
commitf45ff5c60b7464dc250671d58c969a6320aad9b6 (patch)
tree11c01905bf576df18fee42fc5fe7a97f66bda286 /elf/segment.lua
parent96e49359ded717d7e3953875a50e59eb06a5233e (diff)
Refactor normalize() to prevent in-place mutation.
We would need to distinguish user configuration options from normalization. Let normalize() return a new table instead of in-place update. Split annotations into xxxOptions and xxx for header, segments and sections, delineating optional vs normalized table. Leave header, segments and sections as just a data table for now and stop trying to make them objects. Leave data alone.
Diffstat (limited to 'elf/segment.lua')
-rw-r--r--elf/segment.lua98
1 files changed, 52 insertions, 46 deletions
diff --git a/elf/segment.lua b/elf/segment.lua
index 59863b5..dd3d01f 100644
--- a/elf/segment.lua
+++ b/elf/segment.lua
@@ -1,77 +1,83 @@
local ec = require("elf.constants")
local fmt = require("elf.fmt")
----@class Segment
----@field type SegmentType
----@field flags? integer
----@field offset? integer
----@field vaddr? integer
----@field paddr? integer
----@field filesz? integer
----@field memsz? integer
----@field align? integer
+---@class SegmentOptions
+---@field type SegmentType
+---@field flags? integer
+---@field offset? integer
+---@field vaddr? integer
+---@field paddr? integer
+---@field filesz? integer
+---@field memsz? integer
+---@field align? integer
---@field first_section? string
----@field last_section? string
-local M = {}
+---@field last_section? string
+
+---@class Segment
+---@field type SegmentType
+---@field flags integer
+---@field offset integer
+---@field vaddr integer
+---@field paddr integer
+---@field filesz integer
+---@field memsz integer
+---@field align integer
+---@field first_section string
+---@field last_section string
-function M.normalize(phdr)
- if not phdr.type then error("type is required in segment", 3) end
+local M = {}
- phdr.flags = phdr.flags or 0
- phdr.offset = phdr.offset or 0
- phdr.vaddr = phdr.vaddr or 0
- phdr.paddr = phdr.paddr or 0
- phdr.filesz = phdr.filesz or 0
- phdr.memsz = phdr.memsz or 0
- phdr.align = phdr.align or 1
-end
+---@param segopts SegmentOptions
+---@return Segment
+function M.normalize(segopts)
+ if not segopts.type then error("type is required in segment", 3) end
-function M.validate(phdr)
- -- TODO validations
+ return {
+ type = segopts.type,
+ flags = segopts.flags or 0,
+ offset = segopts.offset or 0,
+ vaddr = segopts.vaddr or 0,
+ paddr = segopts.paddr or 0,
+ filesz = segopts.filesz or 0,
+ memsz = segopts.memsz or 0,
+ align = segopts.align or 1,
+ first_section = "",
+ last_section = ""
+ }
end
----@param phdr Segment
+---@param phdr Segment
---@param endian Endian
---@return string
---@nodiscard
local function pack32(phdr, endian)
return string.pack(
- fmt.endian(endian) .. string.rep(fmt.word(ec.Class.bit32), 8),
- phdr.type,
- phdr.offset,
- phdr.vaddr,
- phdr.paddr,
- phdr.filesz,
- phdr.memsz,
- phdr.flags,
- phdr.align)
+ fmt.endian(endian) .. string.rep(fmt.word(ec.Class.bit32), 8), phdr.type,
+ phdr.offset, phdr.vaddr, phdr.paddr, phdr.filesz, phdr.memsz, phdr.flags,
+ phdr.align
+ )
end
----@param phdr Segment
+---@param phdr Segment
---@param endian Endian
---@return string
---@nodiscard
local function pack64(phdr, endian)
return string.pack(
fmt.endian(endian) .. "I4I4" .. string.rep(fmt.word(ec.Class.bit64), 6),
- phdr.type,
- phdr.flags,
- phdr.offset,
- phdr.vaddr,
- phdr.paddr,
- phdr.filesz,
- phdr.memsz,
- phdr.align)
+ phdr.type, phdr.flags, phdr.offset, phdr.vaddr, phdr.paddr, phdr.filesz,
+ phdr.memsz, phdr.align
+ )
end
----@param phdr Segment
+---@param phdr Segment
---@param endian Endian
----@param class Class
+---@param class Class
---@return string
---@nodiscard
function M.pack(phdr, endian, class)
- return (class == ec.Class.bit32) and
- pack32(phdr, endian) or pack64(phdr, endian)
+ return (class == ec.Class.bit32) and pack32(phdr, endian)
+ or pack64(phdr, endian)
end
return M