From f7fc6ce230ee2dd3e31c6ddf2e00f9f51fe2e90e Mon Sep 17 00:00:00 2001 From: Sunil Nimmagadda Date: Tue, 27 Oct 2026 10:26:30 +0530 Subject: Move error checks here. We already check for these missing fields with a nice source line highlighting in config with error(). Better than assert(). --- elf/header.lua | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/elf/header.lua b/elf/header.lua index 4ea8434..c0b8eab 100644 --- a/elf/header.lua +++ b/elf/header.lua @@ -26,11 +26,10 @@ local ec = require("elf.constants") local M = {} function M.normalize(hdr) - assert(type(hdr) == "table", "header must be a table") - assert(hdr.class ~= nil, "missing header field: class") - assert(hdr.data ~= nil, "missing header field: data") - assert(hdr.type ~= nil, "missing header field: type") - assert(hdr.machine ~= nil, "missing header field: machine") + if not hdr.class then error("class is required in header", 3) end + if not hdr.data then error("data is required in header", 3) end + if not hdr.type then error("type is required in header", 3) end + if not hdr.machine then error("machine is required in header", 3) end hdr.magic = hdr.magic or { 0x7f, 0x45, 0x4c, 0x46 } hdr.ident_version = hdr.ident_version or ec.VERSION @@ -50,11 +49,6 @@ function M.normalize(hdr) end function M.validate(hdr) - if not hdr.class then error("class is required in header", 3) end - if not hdr.data then error("data is required in header", 3) end - if not hdr.type then error("type is required in header", 3) end - if not hdr.machine then error("machine is required in header", 3) end - if hdr.class ~= ec.Class.bit32 and hdr.class ~= ec.Class.bit64 then error("class must be Class.bit32 or Class.bit64 in header", 3) end -- cgit v1.3